Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat reviewstate api integration #1376

Merged

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1238

Describe this PR

This PR integrates the post review state API in the frontend side.

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added the frontend Related to frontend code label Mar 21, 2024
@NSUWAL123 NSUWAL123 marked this pull request as ready for review March 25, 2024 02:49
@@ -5,3 +5,7 @@ export const isInputEmpty = (text: string): boolean => {
const trimmedText = text.trim();
return trimmedText === '';
};

export const camelToFlat = (word: string): string => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term for output like

Some Title String

is 'title case' so this could be camelToTitleCase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference the other types are

Snake_Case, used by Python

Kebab-case, used in HTML

πŸ‘

@NSUWAL123
Copy link
Contributor Author

@spwoodcock, could you merge this PR for now. I will update the naming on another PR as I have deleted all my local branches

@varun2948 varun2948 merged commit 4007e2b into hotosm:development Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants